typesync improvements #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwhited
reviewed
Jul 1, 2025
Comment on lines
+377
to
+382
| onChange={(e) => { | ||
| createAppForm.setFieldValue( | ||
| 'directory', | ||
| `./${pipe(e.target.value, EffectString.toLowerCase, EffectString.replaceAll(/\s/g, '-'))}`, | ||
| ); | ||
| }} |
There was a problem hiding this comment.
Why not use the listeners object on the createAppForm.AppField? It has an onChange as well.
There was a problem hiding this comment.
no objection to use listener
sadly I'm not familiar with the TypeSync codebase nor TanStack Forms. Is listeners recommended by Tanstack forms or are there other benefits?
| return [importStatement, typeDefinitions].join('\n\n'); | ||
| } | ||
|
|
||
| export function buildMappingFile(schema: Domain.InsertAppSchema) { |
There was a problem hiding this comment.
Many of the properties won't have knowledgeGraphId if it is a custom property. So I think we should filter out the properties where property.knowledgeGraphId is null, yeah?
There was a problem hiding this comment.
spot on, created an issue here #301
can you pick it up? otherwise I do it as soon as I resolved the other urgent tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.